All times are UTC


Dear guest, welcome to YouTD!

Enchanted Knives by boekie
Name General Description
1, 2, 3, 4, 5, 6
Enchanted Knives v5
2500
UNIQUE
General
Wave lvl: 60

Submission
By: boekie
Date:2010-01-13 12:31:28
Status:
IN THE MAP beta v0.6
ID:120
Last Update:2015-03-06 08:16:35
Description
These knives were used by a famous nightelf ranger. They can attack multiple units at once.

Abilities
Multishot
Attacks up to 3 targets at the same time.
Specials

Specials:
-50% attackspeed


1, 2, 3, 4, 5, 6
Reply to topic

Discussion

Page 5 of 6 [ 84 posts ] Go to page Previous  1, 2, 3, 4, 5, 6  Next
Author Message
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Thu Dec 06, 2012 6:28 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Thu May 20, 2010 8:11 pm
Posts: 1601
Location: Germany
The number exactly shows how much damage was dealt after all modifications (race/size bonus, crit damage, buffs/debuffs, armor value/type, ...).
So yes, the number raises but the extra damage is still not affected by that crit.
The Watchtower with the Blaster Staff should exactly deal 160 damage if your provided data is correct. Maybe the target was already debuffed by something else, or maybe it was ethereal?


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Thu Dec 06, 2012 7:01 pm 
Offline
Super User
User avatar

Joined: Wed May 09, 2012 1:30 pm
Posts: 483
It was very beginning, the only debuff was "burn" from WT. I chose pure Fire to start, so i had no additional debuffs, and almost no items except Blaster Staff.

EDIT:
Well, maybe i am not that good at code reading, but this is interesting part of WT's code:
    // Increase damage gain and do direct damage to the target by setting the event damage
    function damageOnFireAttack takes Buff b returns nothing
        local real    damageGain
        local real    damageFactor
        local Unit    attacker       = Event.getTarget()
        local boolean isBurningTower
        if(Element.FIRE == attacker.getCategory()) then
            set isBurningTower = Tower(attacker).getFamily() == Tower(b.getCaster()).getFamily()
            if(isBurningTower) then
                set damageFactor = 1.0*b.getCaster().getProp_SpellDmgDealt() // Burning Tower
            else
                set damageFactor = 0.3 // is other fire tower
            endif
            set  damageGain   = damageFactor * b.getLevel()
            set  b.userReal   = b.userReal + damageGain
            set  Event.damage = (Event.damage + b.userReal)


Quote:
if(isBurningTower) then
set damageFactor = 1.0*b.getCaster().getProp_SpellDmgDealt() // Burning Tower
else
set damageFactor = 0.3 // is other fire tower
endif

As i can see, this determines, if bonus damage is "full" or "partial".
Quote:
set damageGain = damageFactor * b.getLevel()

Calculates actual bonus damage to add, based on tower level (hm, in case of other Fire towers - is it still buffer's level, or actual hitter level?).
Quote:
set b.userReal = b.userReal + damageGain

Dunno, some in-between variable to make things simplier (or not, lol).
Quote:
set Event.damage = (Event.damage + b.userReal)

And now i get feeling that code modifies whole dealt damage on the fly. Question is: in what order crit calculation and this code work?

But then we have this:
Quote:
The damage system works roughly as following:
1) Attack
3) Hit. Damage is calculated including race/size bonuses and crit
4.1) onDamage event of tower
4.2) onDamage event of items
4.3) onDamaged event of buffs
5) Damage is applied

Does crit calculation actually happen before 4.1-4.3?


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 4:54 am 
Offline
Light User

Joined: Mon Nov 19, 2012 9:12 pm
Posts: 20
does this work with trigger effects like priest smite? if so that would be very op as the priest atk speed differential makes up for this nearly entirely on its own. just need 2 oils for it.

_________________
Image
"I'm Your F**king Nightmare" - Avenged Sevenfold


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 4:57 am 
Offline
YouTD Admin
YouTD Admin
User avatar

Joined: Mon May 02, 2011 10:51 pm
Posts: 1701
Location: Texas/New Jersey(Azeroth)
yes the split shot of enchanted knives does proc smite

_________________
Image


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 1:17 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Thu May 20, 2010 8:11 pm
Posts: 1601
Location: Germany
For the third time: Crit is calculated before any onDamage events are executed so Event.damage contains the damage after crit which then is further modified by watchtower's buff by simply adding the damage.

b.userReal = b.userReal + damageGain

This code simply saves the current damage bonus in the buff (b is the buff). The next attacks will get the bonus damage (Event.damage = Event.damage + b.userReal) and further increase that damage (b.userReal = b.userReal + damageGain).


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 1:29 pm 
Offline
Super User
User avatar

Joined: Wed May 09, 2012 1:30 pm
Posts: 483
Quote:
For the third time: Crit is calculated before any onDamage events are executed so Event.damage contains the damage after crit which then is further modified by watchtower's buff by simply adding the damage.

Ok, then all this "burn" idea really sucks...


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 1:33 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Thu May 20, 2010 8:11 pm
Posts: 1601
Location: Germany
You can suggest a change that the Watchtower takes crits into account (or even race/size bonuses). Btw. one strenght of the buff is that it completely ignores armor as the damage is added after armor reductions.


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 4:57 pm 
Offline
Power User

Joined: Wed Sep 28, 2011 9:06 am
Posts: 1050
I thought the burning was spell damage and goes through armor anyway. no?


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 5:16 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Thu May 20, 2010 8:11 pm
Posts: 1601
Location: Germany
hokkei wrote:
I thought the burning was spell damage and goes through armor anyway. no?


No, it directly modifies the damage dealt, that means it's the same damage type. The extra damage, however, ignores all kind of reductions so it doesn't really matter what kind of damage it is.
The only situation in which it's important is when a creep has a debuff which enhances/reduces damage of that type because that will affect the extra damage if and only if the debuff's onDamaged event handler is executed after the onDamaged event handler of watchtower's buff (it's more or less random which event handler is executed first). AFAIK there is currently no tower which places such a buff so this information is rather useless.


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v2 (120)
PostPosted: Fri Dec 07, 2012 5:21 pm 
Offline
Super User
User avatar

Joined: Wed May 09, 2012 1:30 pm
Posts: 483
hokkei wrote:
I thought the burning was spell damage and goes through armor anyway. no?


Looking at code i'd rather say "no". I thought it's still elemental damage, as in case of Phoenix. Or code just uses hitting tower's damage type...

Nvm, ninja'ed


Top
 Profile  
 
 Post subject: Update to version v3!
PostPosted: Mon Feb 17, 2014 11:36 pm 
Offline
YouTD developer
YouTD developer
User avatar

Joined: Wed Dec 29, 2010 12:20 pm
Posts: 4526
Location: Australia
The item has been updated to version v3!

Creator's reason for this update:

-fixed a leak


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v3 (120)
PostPosted: Tue Feb 18, 2014 12:47 pm 
Offline
Super User

Joined: Fri Mar 30, 2012 1:19 am
Posts: 299
When will we have additional projectiles from knives to be able to carry all properties of main attack? I'm sure most rare item of YouTD deserve such upgrade, but i'm not sure if warcraft/youtd can handle such pressure - it will be a mess of procs :mrgreen:

_________________
YouTD Garena group id: 767512
http://tinyurl.com/ptwgkn3 - 1st solo extreme (U)
http://tinyurl.com/qzwdtuw - 2nd solo extreme (L)
http://tinyurl.com/pjuuqqo - 1st team extreme
http://tinyurl.com/jvjwr6e - 2nd team extreme


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v3 (120)
PostPosted: Tue Feb 18, 2014 2:35 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Sat Jan 16, 2010 2:35 am
Posts: 1924
Actually things have been going the other way. Event.isMainTarget and things like that didn't always exist. As for API methods for calling a tower's onAttack and onDamage events, it has been requested before and tentatively declined.


Top
 Profile  
 
 Post subject: Re: Enchanted Knives v3 (120)
PostPosted: Thu Feb 20, 2014 2:56 pm 
Offline
YouTD Admin
YouTD Admin

Joined: Sun Jun 07, 2009 3:34 pm
Posts: 3006
Also, this item is already one of the best.

_________________
[23:05] <mOck> cedi logic is basically
[23:05] <mOck> fuck the police
Image


Top
 Profile  
 
 Post subject: Re: Enchanted Knives (120)
PostPosted: Thu Jun 19, 2014 11:42 am 
Offline
Super User
User avatar

Joined: Tue Jun 17, 2014 1:44 pm
Posts: 357
Location: RU
cedi wrote:
I guess this item should be redone. It uses the barrage ability and I think that can mess up towers which have also the barrage ability. Either this item will have no effect on these towers or it deactivates the towers multishot. So I suggest you do the same as the chameleon glaive and create the missiles per trigger.


Me feels the same.

However these glaive projectilles as I see in the code have 850 or 950 range. So if you put on Flashing Monument this item you do not benefit at higher attack ranges.

My personal favour is Bug City, Jungle Stalker, Hall of Souls as they have decent to high as and permanent damage bonus. Do not like on Burrow though it's agood idea, but makes Burrow extremely slow. Also don't like on Nerubian Queen as it greatly decreases chances to inject parasite. Could also work fine on Fire Pit but I haven't tested yet.

_________________
Image


Top
 Profile  
 
Display posts from previous:  Sort by  
Reply to topic  [ 84 posts ]  Go to page Previous  1, 2, 3, 4, 5, 6  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group